Skip to content

Conversation

@antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Oct 23, 2025

The PR adds the implementation of dpnp.frexp and extends the framework to support a unary function with two output arrays, including new wrappers in ufunc pybind11 extension and new python class DPNPUnaryTwoOutputsFunc.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@antonwolfy antonwolfy added this to the 0.20.0 release milestone Oct 23, 2025
@antonwolfy antonwolfy self-assigned this Oct 23, 2025
@github-actions
Copy link
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/pull/2635/index.html

@coveralls
Copy link
Collaborator

coveralls commented Oct 23, 2025

Coverage Status

coverage: 81.397% (-0.1%) from 81.511%
when pulling 9a707ac on impl-frexp
into 6b8ea9e on master.

@antonwolfy antonwolfy force-pushed the impl-frexp branch 3 times, most recently from d666152 to 65f3d15 Compare October 27, 2025 11:19
@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2025

Array API standard conformance tests for dpnp=0.20.0dev0=py313h509198e_58 ran successfully.
Passed: 1227
Failed: 0
Skipped: 9

@antonwolfy antonwolfy force-pushed the impl-frexp branch 2 times, most recently from 6cb2237 to fe2fea1 Compare October 28, 2025 14:57
@antonwolfy antonwolfy marked this pull request as ready for review October 28, 2025 14:57
@vlad-perevezentsev vlad-perevezentsev self-requested a review November 6, 2025 13:48
Copy link
Contributor

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, LGTM
Thank you @antonwolfy !

@antonwolfy antonwolfy merged commit b7d1572 into master Nov 6, 2025
118 of 120 checks passed
@antonwolfy antonwolfy deleted the impl-frexp branch November 6, 2025 17:31
github-actions bot added a commit that referenced this pull request Nov 6, 2025
The PR adds the implementation of `dpnp.frexp` and extends the framework
to support a unary function with two output arrays, including new
wrappers in `ufunc` pybind11 extension and new python class
`DPNPUnaryTwoOutputsFunc`. b7d1572
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants